ID popup in Cluster Status widget not valid anymore

Description

In response for GET /cluster-status there was a change in relation to node_id field. Previously each node has node_id parameter defined (path: services.[manager|db|broker].nodes.[node-name].node_id). Right now there is no such field and there are no plans to bring it back.

In Cluster Status widget we used to show such ID in the popup (triggered with "ID" label in column on the right side of the table):

We need to remove the popup from Cluster Status widget as it is not necessary anymore.

Unique key used for identification of the row should be changed to such pair: (cluster service type - manager/db/broker, node private_id)

Steps to Reproduce

Environment:
OS (CLI), HA cluster, cloud provider
------------------------------------
UI

Steps to reproduce:
------------------
1. Open Admin Operations page
2. Hover over ID label

Expected result:
---------------
Node ID + "Copy ID" button presented in the popup or no "ID" label presented at all.

Actual result:
-------------
Only "Copy ID" button presented in the popup.

Why Propose Close?

None

Activity

Show:
Jakub Niezgoda
October 16, 2020, 10:18 AM

FYI - issue we discussed.

, After recent changes in Status Reporter, one of the fields which were present in the /cluster-status response are now not available. Please take a look. I’ll fix it for 5.2, the question is are we doing anything with 5.1? It is not braking anything, the popup is just not necessary as it now displays only “Copy ID” button which on-click copies nothing.

Jakub Niezgoda
October 16, 2020, 12:57 PM

PR with change for 5.2 created: Attached screenshots there how it looks like before/after.

Ofer Yarom
October 18, 2020, 6:21 AM

Based on the new patching concept, changing the version to 5.1.1.

Jakub Niezgoda
October 20, 2020, 11:55 AM

Change merged to master.

Fixed

Assignee

Jakub Niezgoda

Reporter

Jakub Niezgoda

Labels

Severity

Medium

Target Version

5.1.1

Premium Only

no

Found In Version

5.1

QA Owner

None

Bug Type

new feature bug

Customer Encountered

No

Customer Name

None

Release Notes

yes

Priority

None

Epic Link

Sprint

None

Priority

Unprioritized
Configure