Adding a plugin in Composer using Plugins page modifies blueprint imports section improperly

Description

See steps to Reproduce for details.

The result of adding a plugin using Plugins page - either Add Plugin from URL or Add Plugin from Catalog can be observed here:

Steps to Reproduce

Environment:
OS (CLI), HA cluster, cloud provider
------------------------------------

Steps to reproduce:
------------------
1. Open Composer
2. Open new blueprint Plugins page
3. Click Add Plugin from Catalog, select any of the plugins and click Add icon
4. Switch to blueprint YAML source view (Resources > blueprint.yaml)

Expected result:
---------------
No additional characters added to imports section in yaml file.

Actual result:
-------------
Additional characters (">-") added to yaml file.

Why Propose Close?

None

Activity

Show:
Jakub Niezgoda
August 12, 2020, 11:29 AM

Not sure if I understand you correctly. Are you suggesting to use plugin:cloudify-vsphere-plugin syntax on adding plugin to blueprint in Composer instead of http://repository.cloudifysource.org/cloudify/wagons/cloudify-vsphere-plugin/2.18.3/plugin.yaml? That we also thought about, but that is more complex as to validate properly such blueprint we would need to upload cloudify-vsphere-plugin to the manager. It’s doable of course, but I think that’s separate issue.

Alex Molev
August 12, 2020, 11:44 AM

I think that preferable is the cloudify-vsphere-plugin, but if we want to keep the url I would replace

http://repository.cloudifysource.org/cloudify/wagons/cloudify-vsphere-plugin/2.18.3/plugin.yaml

with

http://repository.cloudifysource.org/cloudify/wagons/cloudify-vsphere-plugin/latest/plugin.yaml

Jakub Niezgoda
August 13, 2020, 6:23 AM

I think the link to the yaml file is taken from plugins.json - http://repository.cloudifysource.org/cloudify/wagons/plugins.json, so if it would be updated there, then we will have latest in Composer as well. But such change will also affect all the Cloudify Manager instances using Plugins Catalog widget, so I think that’s not the right way to go. Maybe we would need another external JSON resource for Composer, but that’s separate discussion probably.

Ofer Yarom
August 20, 2020, 6:46 AM
Edited

After our call on the subject, it looks like it could be a potential solution to modify the plugins json such that the plugin.yaml link will point to 'latest'.

to check that with Trammell.

Jakub Niezgoda
August 24, 2020, 11:27 AM
Edited

Change on UI side implemented (PR). Unassigned myself from the issue and moved to to decide what to do next with it.

Fixed

Assignee

Alex Molev

Reporter

Jakub Niezgoda

Labels

Severity

High

Target Version

5.1

Premium Only

yes

Found In Version

5.1

QA Owner

None

Bug Type

unknown

Customer Encountered

No

Customer Name

None

Release Notes

yes

Priority

None

Epic Link

Sprint

None

Priority

Major
Configure