Workflows parameters should be in the same order as defined

Description

When we define custom workflows in a plugin, the execution parameters for those workflows appear in consistent but apparently random orders in the web UI, when executing workflows.
For example, one workflow defined in a plugin.yaml specifies the parameters:

partners
groups
software
hardware
enabled

These show up in the "Execute workflow" dialog box in the following order:

hardware
groups
enabled
partners
software

hardware and software version are closely related, as are groups and partners. It doesn't make much sense out of order.
We should keep the order of the list as it was defined in the yaml file - Use OrderedDict instead of Dict for parsing and reading.

Activity

Show:
Jakub Niezgoda
August 6, 2020, 6:47 AM

Thanks for that explanation. I wasn’t aware of how it works in CLI. So now it perfectly make sense for me to wait with it and not introduce unprepared changes.

Alex Molev
August 6, 2020, 6:49 AM

The last thing I want is the core team to be involved. is it something that can be done easily only on the FE side ? Or you need core team to be involved?

Ofer Yarom
August 6, 2020, 6:59 AM

Apologies if the above was not clear. I am not suggesting that the core team would be involved. on the contrary, I think this should be handled at the UI level.

That said, the design is more complex than just modifying the order as we will probably wish to allow the user to define which method they prefer. because of that, I would like to wait for 5.2.

Jonathan Abramsohn
August 6, 2020, 8:27 AM

, , , Jira was created in 2018, since we’ve done a lot of changes in UI and CLI. Apparently it looks redundant now, so let’s hold the work on it.

I will make sure with the customer that the current situation as it is in 5.1, although it’s not what they asked for. is something they can accept.

Alex Molev
August 6, 2020, 9:16 AM

Ok, if you find there is no need in it please close the Jira issue

Assignee

Jakub Niezgoda

Reporter

Jonathan Abramsohn

Target Version

5.2

QA Owner

None

Premium Only

no

Documentation Required

No

Why Blocked?

None

Release Notes

yes

Priority

None

Priority

Unprioritized
Configure