Snapshot restore failing on 5.1 py3 compatibility issues

Description

during the test of trying to do restore from 4.3.3 to 5.1 for testing purposes the snapshot restore failed due to errors with workflow scripts not being compatible with py3

so the exception is :

https://github.com/cloudify-cosmo/cloudify-manager/blob/master/workflows/cloudify_system_workflows/snapshots/postgres.py#L501

and fix for that was to drop the decode , and one more issue arose after that

exception :

and the fix for that is to replace bytes to value.encode('utf-8')

https://github.com/cloudify-cosmo/cloudify-manager/blob/master/workflows/cloudify_system_workflows/snapshots/postgres.py#L579

Activity

Show:
Ahmad Musa
May 21, 2020, 8:17 AM

I created a PR and it was approved and merged to master https://github.com/cloudify-cosmo/cloudify-manager/pull/2193

Cc

 

 

Done

Assignee

Ahmad Musa

Reporter

Ahmad Musa

Target Version

5.1

QA Owner

None

Premium Only

no

Documentation Required

Yes

Why Blocked?

None

Release Notes

yes

Priority

Medium

Epic Link

Sprint

None

Priority

Medium
Configure