Script plugin doesn't kill sub-processes on cancel or kill cancel

Description

If you use any cancellation other than kill cancel on a workflow with a script plugin operation, the sub-processes will be left there until the operation terminates. This is because the script plugin never yields back to the manager (ie: raising an operation retry) and has no handling for cancellation. This is especially bad if a script never terminates since that subprocess will continue to take up mgmtworker worker counts.

Steps to Reproduce

Environment:
OS (CLI), HA cluster, cloud provider
------------------------------------

Steps to reproduce:
------------------
1.
2.
3.

Expected result:
---------------

Actual result:
-------------

Why Propose Close?

None

Activity

Show:
Barak Azulay
November 17, 2019, 11:14 AM

I am not sure but tut this may also be related also to

Please check and ping me when you have more understanding of the problem / solution

Mohammed Abuaisha
November 17, 2019, 11:16 AM

will take a look once wrap the stuff related to spire and will update this Jira with my finding

Mohammed Abuaisha
November 20, 2019, 3:51 PM

I think the main issue for this card is not related to script plugin, its highly related to since I was able to reproduce this issue and when cancel the workflow the process in the agent host still running without being killed.

I did not spend much time on it since I was working in other stuff so I think the root cause for this issue is how the stop of the subprocesses being handled which need more investigation

Barak Azulay
November 20, 2019, 4:38 PM

When you have verified it is the same problem than please close this Jira as duplicate of (which I have assigned to you … although this seem to be a backend issue)

Mohammed Abuaisha
November 21, 2019, 7:29 AM

Sure will close this jira,

Will close this Jira since the root cause of the issue is this Jira

Assignee

Mohammed Abuaisha

Reporter

Jonathan Abramsohn

Labels

Severity

High

Target Version

5.0.5

Premium Only

no

Found In Version

4.5

QA Owner

None

Bug Type

unknown

Customer Encountered

Yes

Customer Name

c458

Release Notes

yes

Priority

None

Priority

Unprioritized
Configure