Fix UI linter issues

Description

Within new ESLint configuration was introduced in cloudify-stage. All UI projects are using ESLint now.

Most of the problems found were automatically fixed by ESLint, but there were >10k problems not possible to fix automatically. All listed here: UI - ESLint issues

ESLint configuration was changed to treat all not fixed problems as warnings (that way ESLint check used in CI - `npm run lint` - is not failing). We need to fix all the errors and remove that configuration override.

We should also fix the issues in cloudify-blueprint-composer and cloudify-blueprint-topology.

This story is huge, so it should be splitted into smaller parts using sub-tasks.

Potentially useful codemods:

  1. https://github.com/sejoker/awesome-jscodeshift/blob/master/readme.md#codemods

  2. https://github.com/cpojer/js-codemod/

Activity

Show:
Jakub Niezgoda
January 9, 2020, 8:35 AM

Motivation

  • for Cloudify - ease of maintenance, bug reduction

  • currently most of the issues reported as errors in cloudify-ui-components, cloudify-ui-common or cloudify-blueprint-composer are reported as warnings in cloudify-stage. That’s because cloudify-stage has the biggest codebase from all of the listed and ESLint was not introduced in cloudify-stage from the beginning

  • I’d like to have that implemented, but I understand the cost here can be high with low short-term value for customer.

Effort

  • quick review and update the most important is probably day up to few days

  • full review and thorough update is probably about a week

 

Alex Molev
April 5, 2020, 5:16 PM

let’s try to invest few days every week and spread it between 3-4 weeks, so we will have sometime for features, improvements and if there will be any unknown bugs.

On Wednesday we are going to have Sprint planing so I we will need to have some idea how we want to break it down and what part do we want to achieve in the upcoming sprint

Jakub Niezgoda
April 6, 2020, 6:25 AM

OK, I’m putting that on my TODO list. I remember that I had already some ideas how to divide it. Need to review again. I’ll create sub-tasks in that Jira before Sprint planning.

Jakub Niezgoda
April 8, 2020, 7:58 AM

I divided the story into sub-tasks. Basically cloudify-blueprint-topology and cloudify-blueprint-composer are in single sub-tasks and divided cloudify-stage into smaller parts as there are significantly more issues. I was basing on the analysis I did today - details in the document - UI - ESLint issues.

Done

Assignee

Jakub Niezgoda

Reporter

Jakub Niezgoda

Target Version

5.2

Premium Only

no

Documentation Required

Yes

Why Blocked?

None

Release Notes

yes

Priority

Medium

Priority

Medium

Epic Name

Fix UI linter issues
Configure